Implement sorting of query history by name, date, and result count #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
reviewed
Mar 11, 2021
| @@ -400,6 +400,7 @@ export class InterfaceManager extends DisposableObject { | |||
| } | |||
| ); | |||
| const resultSet = transformBqrsResultSet(schema, chunk); | |||
| results.setResultCount(resultSet.schema.rows); | |||
There was a problem hiding this comment.
This is a little confusing. The alerts table has 33 results in this example, but the #select table has 3906 results. I think people would expect that the result count matches the number of rows in the default table (in this case, it's alerts).
I'm not entirely sure why there is a difference here. I'm just running the example query from the starter repo:
/**
* @name Empty block
* @kind problem
* @problem.severity warning
* @id javascript/example/empty-block
*/
import javascript
from BlockStmt b
where b.getNumStmt() = 0
select b, "This is an empty block."It would be nice if we could get the counts for the default table, but I'm not sure how easy this is without loading the sarif.
aeisenberg
approved these changes
Mar 15, 2021
|
Can you squash and rebase your commits? |
edoardopirovano
force-pushed
the
history-sorting
branch
from
bca5000
to
bda80c2
Compare
aeisenberg
requested changes
Mar 15, 2021
edoardopirovano
force-pushed
the
history-sorting
branch
from
3e3a405
to
719d5c9
Compare
aeisenberg
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #767 by introducing three ways of sorting the query history view - by a query's label, by the date the query was run, and by the number of results the query produced.