Ensure the logFileLocation is set
#2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`logFileLocation` was not set after a query finishes running. I don't know when this bug was introduced. I think it goes as far back as the refactor to remove the old query server.
angelapwen
approved these changes
Oct 17, 2023
I think the code scanning warning can be dismissed as the line in question is not actually assigning a value.
|
Thanks for the review. Still need to add a change note. |
Also, avoid a code scanning warning.
|
The code scanning warning was legitimate since there was a value being assigned in the constructor parameter list as well as the constructor body. I refactored a bit so there is no warning. |
Ah I see.. I think the location it showed up on was a bit misleading (because it didn't show on any assignment). Thanks! |
angelapwen
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logFileLocationwas not set after a query finishes running. I don't know when this bug was introduced. I think it goes as far back as the refactor to remove the old query server.Replace this with a description of the changes your pull request makes.
Checklist
ready-for-doc-reviewlabel there.