Do not show non-workspace packs when installing pack dependencies #2960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the "CodeQL: Install pack dependencies" command, we would show packs that are located in the package cache or distribution. Since there are no dependencies to install for these packs, these options are not useful. This will filter out any packs that are not in the workspace folders when showing the quick pick. This should exclude most packs if you are in a workspace without the `codeql` submodule and should be a lot more intuitive in those cases. If you are in a workspace with the `codeql` submodule, it will still show all the packs.
koesie10
added a commit
that referenced
this pull request
Oct 16, 2023
koesie10
added a commit
that referenced
this pull request
Oct 16, 2023
…pace-packs Add CHANGELOG entry for #2960
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the "CodeQL: Install pack dependencies" command, we would show packs that are located in the package cache or distribution. Since there are no dependencies to install for these packs, these options are not useful.
This will filter out any packs that are not in the workspace folders when showing the quick pick. This should exclude most packs if you are in a workspace without the
codeqlsubmodule and should be a lot more intuitive in those cases. If you are in a workspace with thecodeqlsubmodule, it will still show all the packs.Before:
After:
Checklist
ready-for-doc-reviewlabel there.