Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash result set name in sorted result set path #2955

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Hash result set name in sorted result set path #2955

merged 1 commit into from
Oct 12, 2023

Conversation

kaspersv
Copy link
Contributor

@kaspersv kaspersv commented Oct 12, 2023 •
edited
Loading

This PR changes the filename used for sorted result sets from using the result set name directly to using a hash. Using a hash is preferable as the result set names are generated from the named results of the final stage. It is therefore partially under user-control and may contain additional special characters that cannot be used in filenames as the RA name character set is extended.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@kaspersv kaspersv force-pushed the kaspersv/hash-result-set-in-bqrs-filename branch 5 times, most recently from f634945 to 6d1b01d Compare October 12, 2023 09:30
@kaspersv kaspersv marked this pull request as ready for review October 12, 2023 11:10
@kaspersv kaspersv requested a review from a team as a code owner October 12, 2023 11:10
@kaspersv
Copy link
Contributor Author

Build failures should be resolved by #2962.

koesie10
koesie10 reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this! I have some questions about MurmurHash, but the general implementation looks good.

extensions/ql-vscode/src/run-queries-shared.ts Outdated Show resolved Hide resolved
extensions/ql-vscode/package.json Outdated Show resolved Hide resolved
@kaspersv kaspersv force-pushed the kaspersv/hash-result-set-in-bqrs-filename branch from 6d1b01d to ee5b738 Compare October 12, 2023 11:59
koesie10
koesie10 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for implementing those changes

@kaspersv kaspersv merged commit 8ecc31f into main Oct 12, 2023
14 checks passed
@kaspersv kaspersv deleted the kaspersv/hash-result-set-in-bqrs-filename branch October 12, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koesie10 koesie10 koesie10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaspersv @koesie10