Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "result format" dropdown determine result display #2749

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

shati-patel
Copy link
Contributor

@shati-patel shati-patel commented Aug 24, 2023

Follow-up to #2745. Display variant analysis results as rendered alerts or a raw table, depending on the user's selection in the dropdown:

toggle-raw-mrva-results.mp4

For queries that have alerts available (path-problem or problem queries), we display as alerts by default, with the option to swap to raw results. For other queries, we can only show a raw results table, so we don't show the dropdown at all.

Checklist

Base automatically changed from shati-patel/result-format-view to main August 25, 2023 08:46
@shati-patel shati-patel marked this pull request as ready for review August 25, 2023 08:47
@shati-patel shati-patel requested review from a team as code owners August 25, 2023 08:47
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@shati-patel shati-patel merged commit 94edb9b into main Aug 25, 2023
20 of 21 checks passed
@shati-patel shati-patel deleted the shati-patel/implement-dropdown branch August 25, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants