Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queries Panel: run local query from file tab #2544

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Queries Panel: run local query from file tab #2544

merged 1 commit into from
Jun 26, 2023

Conversation

norascheuch
Copy link
Contributor

Adds a run icon to .ql-files and runs local query.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@norascheuch norascheuch requested a review from a team as a code owner June 23, 2023 14:33
shati-patel
shati-patel reviewed Jun 23, 2023
View reviewed changes
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I have a question about the visibility of this command, but looks good otherwise.

(I'm never hugely confident in my reviews though, so I wouldn't mind a second opinion for reviewing/approving 😺)

extensions/ql-vscode/package.json Show resolved Hide resolved
robertbrignull
robertbrignull approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM

I have the same question as @shati-patel about whether we want to feature flag this or not. I agree it pretty independent and could be nice to release it now.

@norascheuch norascheuch merged commit 75d2f76 into main Jun 26, 2023
@norascheuch norascheuch deleted the nora/queries-panel-file-tab branch June 26, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shati-patel shati-patel shati-patel left review comments

@robertbrignull robertbrignull robertbrignull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@norascheuch @robertbrignull @shati-patel