Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update export/copy buttons copy when repositories are selected #2427

Merged
merged 4 commits into from
May 22, 2023

Conversation

koesie10
Copy link
Member

@koesie10 koesie10 commented May 17, 2023

This changes the text of the export/copy buttons on a variant analysis when at least one repository is selected or a filter is applied which filters out part of the repositories. This makes it more clear that the user is only exporting/copying the results of the selected/filtered repositories.

Screen.Recording.2023-05-17.at.15.10.08.mov

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

This changes the text of the export/copy buttons on a variant analysis
when at least one repository is selected. This makes it more clear that
the user is only exporting/copying the results of the selected
repositories.
When the user filters the repositories, the buttons should reflect that
the results are filtered and that the user is not exporting or copying
all the results. If the user has selected repositories, the buttons
should still say that they are exporting selected results.
@koesie10 koesie10 marked this pull request as ready for review May 17, 2023 13:20
@koesie10 koesie10 requested a review from a team as a code owner May 17, 2023 13:20
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changelog entry? Looks great otherwise!

@koesie10 koesie10 requested a review from a team as a code owner May 17, 2023 14:46
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚢

@koesie10 koesie10 enabled auto-merge May 22, 2023 08:52
@koesie10 koesie10 merged commit 4ea1bb5 into main May 22, 2023
@koesie10 koesie10 deleted the koesie10/export-copy-selected-text branch May 22, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants