Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress similar error messages when monitor MRVA #2396

Merged
merged 2 commits into from
May 2, 2023

Conversation

koesie10
Copy link
Member

@koesie10 koesie10 commented May 2, 2023

This will suppress showing the same error message when monitoring the variant analysis fails multiple times in a row. This is useful when e.g. the internet is disconnected or the endpoint is non-functional for any other reason.

This will show the error message at least once, and then only show it if there has been a successful attempt in between or when the error message is different. This should result in a much less noisy experience.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

This will suppress showing the same error message when monitoring the
variant analysis fails multiple times in a row. This is useful when
e.g. the internet is disconnected or the endpoint is non-functional for
any other reason.

This will show the error message at least once, and then only show it
if there has been a successful attempt in between or when the error
message is different. This should result in a much less noisy
experience.
@koesie10 koesie10 added the secexp label May 2, 2023
@koesie10 koesie10 requested a review from a team as a code owner May 2, 2023 12:40
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding tests.

@koesie10 koesie10 merged commit 5360f03 into main May 2, 2023
@koesie10 koesie10 deleted the koesie10/suppress-error-message branch May 2, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants