Restart language server on command #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the language server is restarted when the "Restart Query Server" command is invoked.
aeisenberg
force-pushed
the
aeisenberg/restart-lang-server
branch
from
1c06ef9
to
2e0023f
Compare
|
Curious, I thought this was already done in #1487. |
|
I think that older PR covered the CLI server, but not the language server! |
|
That's right. Previous PR was CLI server only. In general, it's harder to find noticeable errors when a new CLI version is used and the language server isn't restarted. That said, I'm surprised it took so long before we had an issue raised for this. |
angelapwen
reviewed
Mar 24, 2023
| await queryRunner.restartQueryServer(progress, token); | ||
| await Promise.all([ | ||
| queryRunner.restartQueryServer(progress, token), | ||
| ideServer.restart(), |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the language server is restarted when the "Restart Query Server" command is invoked.
This PR fixes the first part of #2199 where there are spurious red squiggles when upgrading to a new CLI version.
Replace this with a description of the changes your pull request makes.
Checklist
ready-for-doc-reviewlabel there.