Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert VSCode version is high enough #1674

Merged
merged 6 commits into from
Nov 15, 2022
Merged

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Oct 28, 2022

Simple change to verify that the vscode version is high enough to support some future features.

Before bumping the engine property of package.json, we will need to first bump the min version in extension.ts, then release that bumped version. Once that extension version is available, people on older versions will get warnings that they need to upgrade. Then we can release a new version of vscode that requires a new minimum version.

Update: Added a way to disable version checks

Version checks are re-enabled whenever the version of vscode changes.
This is because the user would have needed to manually update their
vscode version in order to get this new version. And another failing
version check would mean there is a newer version that needs to be
downloaded.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@aeisenberg aeisenberg requested a review from a team as a code owner October 28, 2022 17:01
@aeisenberg aeisenberg mentioned this pull request Oct 28, 2022
3 tasks
@henrymercer
Copy link
Contributor

Question: Will this be annoying to some users who are forced to be on an older version? An ideal implementation would only warn once, and remember that there was a warning.

Do we have any telemetry information about which VS Code version our users are on?

@aeisenberg
Copy link
Contributor Author

aeisenberg commented Nov 2, 2022

The telemetry is not easy to access at the moment, but it looks like about 4.5% of the users who are sending telemetry are below v1.67 (and would be affected by this change).

I think the key thing to do here is to only ask them to upgrade once in a while (perhaps whenever they upgrade the extension). I'll work on that later in this PR.

@aeisenberg
Copy link
Contributor Author

Better approach will be to continue to show this message on every restart, and also have a "Don't show this again" button.

Version checks are re-enabled whenever the version of vscode changes.
This is because the user would have needed to manually update their
vscode version in order to get this new version. And another failing
version check would mean there is a newer version that needs to be
downloaded.
@aeisenberg aeisenberg merged commit 9a7489f into main Nov 15, 2022
@aeisenberg aeisenberg deleted the aeisenberg/assert-version branch November 15, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants