Avoid error after upgrading a database #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `runUpgrade` query server command is mistakenly caching the old dbscheme in memory after running the upgrade. The problem is in the CLI. The workaround is to restart the query server after running an upgrade. This is not a great solution, but considering that explicit upgrades are now very rare. I do not think it is worth putting in too much effort for a proper fix.
adityasharad
approved these changes
Sep 19, 2022
|
@alexet I am merging this now, but if you want to look at the underlying issue later, we can put in a proper fix at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
runUpgradequery server command is mistakenly caching the old dbscheme in memory after running the upgrade. The problem is in the CLI. The workaround is to restart the query server after running an upgrade. This is not a great solution, but considering that explicit upgrades are now very rare. I do not think it is worth putting in too much effort for a proper fix.Replace this with a description of the changes your pull request makes.
Checklist
ready-for-doc-reviewlabel there.