Only use -Werror in CI #428
Conversation
| @@ -1,3 +1,6 @@ | |||
| -- ATTENTION: care must be taken to keep this file in sync with cabal.project.ci. If you add a package here, add it there (and add a package stanza with ghc-options to enable errors in CI at the bottom of that file). | |||
There was a problem hiding this comment.
These notices are important, and a rather unfortunate necessity: We can’t just pass --ghc-option=-Werror to cabal in CI, because a long-standing bug in cabal causes it to apply ghc-options specified on the CLI to all packages instead of only the local ones.
We could perhaps have added cabal.project.local files specifying -Wwarn for all local packages, but we’d have had to keep those in sync too, and as that file is the target of cabal configure, it would potentially introduce a bunch of work to keep spurious changes to those files out of PRs.
On the balance, this seemed a better solution, albeit unfortunately duplicative; hopefully the ATTENTION notices in these files will remind us to keep things synced up. (And if not, maybe we can add a CI check that cabal.project is a prefix of cabal.project.ci.)
| package semantic-tsx | ||
| ghc-options: -Werror | ||
|
|
||
| package semantic-typescript | ||
| ghc-options: -Werror |
There was a problem hiding this comment.
We were actually already running into trouble keeping these things synced up correctly, as neither of these packages had -Werror in CI until now.
This PR adds new
cabal.projectfiles specifically for CI builds, allowing us to enable-Werror(“hard mode”) only in CI.