Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unknown directive options removing the directive entirely #1452

Merged
merged 2 commits into from
Apr 3, 2021
Merged

fix unknown directive options removing the directive entirely #1452

merged 2 commits into from
Apr 3, 2021

Conversation

terencehonles
Copy link
Contributor

@terencehonles terencehonles commented Mar 9, 2021 •
edited
Loading

Fixes the following:

.. code:: python
	:caption: An ignored Sphinx option

	python.code('hello world')

@terencehonles
Copy link
Contributor Author

terencehonles commented Mar 9, 2021 •
edited
Loading

This should be able to pass after #1453

This was referenced Mar 31, 2021
Merged
Merged
@aharpole
Copy link
Contributor

aharpole commented Apr 2, 2021

@terencehonles can you update this branch? Just want to make sure CI passes and then I'll merge.

@terencehonles terencehonles force-pushed the fix-rst-directives-with-unknown-options branch from 848178f to 09b3232 Compare April 2, 2021 05:02
@terencehonles
Copy link
Contributor Author

@aharpole done! Thanks!

@terencehonles
Copy link
Contributor Author

Looks like the actions still need to be enabled on this repository, but they are running on my fork https://github.com/terencehonles/github-markup/actions/runs/710717856

@terencehonles terencehonles force-pushed the fix-rst-directives-with-unknown-options branch from 09b3232 to 7a19485 Compare April 2, 2021 05:06
@terencehonles
Copy link
Contributor Author

Looks like I misconfigured the workflow triggers. If you'd like me to split out the PRs I can, but looks like the checks are running here now.

aharpole
aharpole approved these changes Apr 3, 2021
View reviewed changes
Copy link
Contributor

@aharpole aharpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for these fixes!

@aharpole aharpole merged commit 4690850 into github:master Apr 3, 2021
@terencehonles terencehonles deleted the fix-rst-directives-with-unknown-options branch April 3, 2021 01:00
@terencehonles terencehonles mentioned this pull request Apr 6, 2021
Open
MintThitiratChamnan
MintThitiratChamnan reviewed Aug 14, 2021
View reviewed changes
Copy link

@MintThitiratChamnan MintThitiratChamnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mint-6263

@ghost
Copy link

ghost commented Aug 14, 2021

#1452

@ghost
Copy link

ghost commented Aug 14, 2021

#1453

@waldyrious waldyrious mentioned this pull request Oct 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MintThitiratChamnan MintThitiratChamnan MintThitiratChamnan left review comments

@aharpole aharpole aharpole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@terencehonles @aharpole @t3000 @MintThitiratChamnan @loy0128913233