Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build_id files from rpm #954

Merged
merged 2 commits into from
May 6, 2021

Conversation

yakirgb
Copy link

@yakirgb yakirgb commented Apr 6, 2021

Related issue: #953

Description

Right now the rpm including unwanted files of /usr/lib/.build-id/ for example:

[root@u1 ~]# rpm -ql gh-ost-1.1.2-1
/usr/bin/gh-ost
/usr/lib/.build-id
/usr/lib/.build-id/c4
/usr/lib/.build-id/c4/dd5acac09d7d035b4a07fdce618a4eab59366c

Based on https://fedoraproject.org/wiki/Changes/ParallelInstallableDebuginfo and https://fedoraproject.org/wiki/Releases/FeatureBuildId , add --rpm-rpmbuild-define "_build_id_links none" will fix the issue.

After the fix:

[root@u1 ~]# rpm -ql  gh-ost-1.1.2-1
/usr/bin/gh-ost

Thank you, Yakir.

Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timvaillancourt
Copy link
Collaborator

Merging as this is build-time only and I confirmed it works 👍

@timvaillancourt timvaillancourt merged commit 8ab0a89 into github:master May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants