Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check to rows.Err after processing all rows #835

Merged
merged 6 commits into from
Aug 20, 2020

Commits on Mar 31, 2020

  1. Add a check to rows.Err after processing all rows

    Closes github#822.
    
    In go-sql-driver/mysql#1075, @acharis notes
    that the way the go-sql driver is written, query timeout errors don't
    get set in `rows.Err()` until _after_ a call to `rows.Next()` is made.
    
    Because this kind of error means there will be no rows in the result
    set, the `for rows.Next()` will never enter the for loop, so we must
    check the value of `rows.Err()` after the loop, and surface the error up
    appropriately.
    ajm188 committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    61de098 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2020

  1. Configuration menu
    Copy the full SHA
    90ad7a0 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2020

  1. Configuration menu
    Copy the full SHA
    5b6da5b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4bbc8de View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2020

  1. Configuration menu
    Copy the full SHA
    f268259 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8b3a8be View commit details
    Browse the repository at this point in the history