Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --mysql-timeout flag #824

Merged
merged 3 commits into from
Aug 19, 2020
Merged

Support --mysql-timeout flag #824

merged 3 commits into from
Aug 19, 2020

Conversation

shlomi-noach
Copy link
Contributor

Looking into #822

This PR adds --mysql-timeout=<float> flag, which controls all these at once:

  • MySQL connect timeout (cap on establishing connection)
  • MySQL read timeout (cap on read query time)
  • MySQL write timeout (cap on write query time).

@shlomi-noach shlomi-noach mentioned this pull request Feb 16, 2020
Closed
evitame78
evitame78 approved these changes Mar 21, 2020
View reviewed changes
Copy link

@evitame78 evitame78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@timvaillancourt timvaillancourt had a problem deploying to production/mysql_role=ghost_testing August 19, 2020 19:37 Failure
@timvaillancourt timvaillancourt merged commit 720182f into master Aug 19, 2020
@timvaillancourt timvaillancourt deleted the connection-timeout branch August 19, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvaillancourt timvaillancourt timvaillancourt approved these changes

@evitame78 evitame78 evitame78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shlomi-noach @timvaillancourt @evitame78