Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binaries for arm64 architectures #1108

Merged
merged 2 commits into from
Mar 11, 2022

Conversation

jecepeda
Copy link
Contributor

A Pull Request should be associated with an Issue.

Related issue: #1105

Description

Now that developers are using different architectures (amd64 and arm64, basically), we need to use different binaries adapted for those architectures.

This PR changes build.sh script, adding binaries for linux/arm64 and darwin/arm64

I needed to rename the .tar.gz files to indicate the architecture. Now its naming is:

./gh-ost-binary-${osshort}-${GOARCH}-${timestamp}.tar.gz

Copy link
Contributor

@dm-2 dm-2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks @jecepeda - looks good to me 👍

@dm-2 dm-2 merged commit 8f361f6 into github:master Mar 11, 2022
@jecepeda jecepeda deleted the add-binaries-for-arm64-architectures branch March 11, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants