fix: use latest ruby and newer jekyll versions #4487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] ruby 3.3.5, update .ruby-version - [x] use latest github-pages gem which uses Jekyll 3.10.0 (from 6/2024) - previous was using jekyll 2.4.0 (was from 10 years ago) - [x] setup .devcontainer for local development - [x] add Gemfile.lock (remove from .gitignore) - [x] update dependabot config to include gems/bundler (weekly) - [x] fix markdown formatting in CONTRIBUTING.md - [x] fix liquid parsing issue of handlebars/index.md (backticks to quotes) - [Error](https://github.com/github/explore/actions/runs/11299945094/job/31431925940#step:6:82) Signed-off-by: jmeridth <[email protected]>
jmeridth
commented
Oct 12, 2024
| @@ -10,4 +10,4 @@ related: mustache-js, ejs-templates, pug, nunjucks, jinja2, liquid, javascript, | |||
| released: February 15, 2011 | |||
| github_url: https://github.com/handlebars-lang | |||
| --- | |||
| **Handlebars** is a simple templating language. It uses a template and an input object to generate HTML or other text formats. Handlebars templates look like regular text with embedded Handlebars expressions. Handlebars is largely compatible with Mustache templates. In most cases it is possible to swap out Mustache with Handlebars and continue using your current templates. A handlebars expression is a `{{`, some contents, followed by a `}}`. When the template is executed, these expressions are replaced with values from an input object. | |||
| **Handlebars** is a simple templating language. It uses a template and an input object to generate HTML or other text formats. Handlebars templates look like regular text with embedded Handlebars expressions. Handlebars is largely compatible with Mustache templates. In most cases it is possible to swap out Mustache with Handlebars and continue using your current templates. A handlebars expression is a "{{", some contents, followed by a "}}". When the template is executed, these expressions are replaced with values from an input object. | |||
There was a problem hiding this comment.
changing from backticks to quotes fixed liquid warning
|
This might be too much for one PR. 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resulting
https://localhost:4000redirects tohttps://localhost:4000/feed.jsonand it includes the whistleblowing content. Still looking into that.My changes listed below in each section under
My ChangesPlease confirm this pull request meets the following requirements:
Which change are you proposing?
Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:
*.png, square, dimensions 288x288, size <= 75 kB)index.md)My Changes
Curating a new topic or collection
https://github.com/topics/[NAME]orhttps://github.com/collections/[NAME])*.pngimage (if applicable) andindex.mdindex.mdconform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docsSomething that does not neatly fit into the binary options above
My Changes
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.