Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tip to Authorizing OAuth Apps about revoking app for SAML SSO issues #9480

Merged
merged 4 commits into from
Sep 9, 2021
Merged

Add tip to Authorizing OAuth Apps about revoking app for SAML SSO issues #9480

merged 4 commits into from
Sep 9, 2021

Conversation

naamunds
Copy link
Contributor

@naamunds naamunds commented Sep 1, 2021

Why:

Closes [issue link]

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Sep 1, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 1, 2021
@ramyaparimi
Copy link
Contributor

@naamunds
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Sep 2, 2021
@Mady0208

This comment has been minimized.

Sign in to view
lecoursen
lecoursen reviewed Sep 9, 2021
View reviewed changes
Copy link
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is very helpful! I'll apply a small suggestion and then merge. ⚡

...thub/authenticating-to-github/keeping-your-account-and-data-secure/authorizing-oauth-apps.md Outdated Show resolved Hide resolved
@lecoursen lecoursen enabled auto-merge September 9, 2021 18:46
@lecoursen lecoursen merged commit c47dc55 into github:main Sep 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Octomerger pushed a commit that referenced this pull request Mar 24, 2023
@am-stead @lecoursen
[2023-03-31] Make images accessible in the images/help/dashboard dire…
381f814 
…ctory #9480 (#35808)

Co-authored-by: Laura Coursen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lecoursen lecoursen lecoursen approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@naamunds @ramyaparimi @Mady0208 @lecoursen @SirJosh1987