Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accuracy of short title on "Migrating OAuth Apps to GitHub Apps" article #9245

Merged
merged 4 commits into from
Sep 1, 2021

Conversation

Hoeksema
Copy link
Contributor

@Hoeksema Hoeksema commented Aug 23, 2021

Why:

https://docs.github.com/en/developers/apps/getting-started-with-apps/migrating-oauth-apps-to-github-apps

The article is about migrating OAuth apps to Github Apps, yet the short title says "Migrate to OAuth Apps" which is confusing when scanning through the documentation.

What's being changed:

Change "to" --> "from" to improve accuracy of short title w.r.t. page contents.

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Aug 23, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 23, 2021
Copy link
Contributor

@ramyaparimi ramyaparimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hoeksema
Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏

@ramyaparimi ramyaparimi added ready to merge This pull request is ready to merge and removed triage Do not begin working on this issue until triaged by the team labels Aug 25, 2021
@ramyaparimi ramyaparimi added the content This issue or pull request belongs to the Docs Content team label Sep 1, 2021
@ramyaparimi ramyaparimi merged commit 453757f into github:main Sep 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@Hoeksema Hoeksema deleted the patch-2 branch September 16, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants