Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update updating-credentials-from-the-macos-keychain.md #7957

Closed
wants to merge 3 commits into from

Conversation

Bishwa05
Copy link

@Bishwa05 Bishwa05 commented Jul 5, 2021

Why:

This page of document does not says we have to update the password with the generated token in key chain.
The PR is created to provide more clarity for mac users.

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Jul 5, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 5, 2021
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jul 6, 2021
@ramyaparimi
Copy link
Contributor

@Bishwa05 Thank you for opening this PR 👍 I will triage this for review ⚡

Copy link

@Avr170411 Avr170411 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si permito

@lecoursen
Copy link
Member

Thanks @Bishwa05! Both of these additions are technically accurate, but not strictly necessary for readers to accomplish their goals. Since every added word makes an article more work to read and therefore less accessible, we want to avoid adding unnecessary extra words. I'm going to close this now but I hope I've explained clearly why I'm doing so! ✨ Thanks again for spending time on this and contributing to our documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants