-
Notifications
You must be signed in to change notification settings - Fork 60k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update updating-credentials-from-the-macos-keychain.md #7957
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@Bishwa05 Thank you for opening this PR 👍 I will triage this for review ⚡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Si permito
Thanks @Bishwa05! Both of these additions are technically accurate, but not strictly necessary for readers to accomplish their goals. Since every added word makes an article more work to read and therefore less accessible, we want to avoid adding unnecessary extra words. I'm going to close this now but I hope I've explained clearly why I'm doing so! ✨ Thanks again for spending time on this and contributing to our documentation. |
Why:
This page of document does not says we have to update the password with the generated token in key chain.
The PR is created to provide more clarity for mac users.
What's being changed:
Check off the following:
Writer impact (This section is for GitHub staff members only):