Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct filter name #7490

Merged
merged 3 commits into from
Jun 21, 2021
Merged

Correct filter name #7490

merged 3 commits into from
Jun 21, 2021

Conversation

Relequestual
Copy link
Contributor

Filter for discussions is is:discussion without the s

Why: Typo in docs. Use of incorrect filter name results in no results

Closes N/A

What's being changed: Fixed a typo

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Filter for discussions is `is:discussion` without the `s`
@welcome
Copy link

welcome bot commented Jun 18, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 18, 2021
Copy link
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @Relequestual and thanks so much for opening an PR! I'll update this branch and get it merged once tests are passing 🍏

@janiceilene janiceilene added ready to merge This pull request is ready to merge and removed triage Do not begin working on this issue until triaged by the team labels Jun 18, 2021
@janiceilene
Copy link
Contributor

It looks like we're having some trouble with our staging checks. I'll come back to get this merged next week! Sorry about the delay 💛

@janiceilene janiceilene merged commit b0c9a1e into github:main Jun 21, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@Relequestual Relequestual deleted the patch-1 branch June 22, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants