Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in action step name #7446

Merged
merged 4 commits into from
Jun 22, 2021
Merged

Fix typo in action step name #7446

merged 4 commits into from
Jun 22, 2021

Conversation

ajs256
Copy link
Contributor

@ajs256 ajs256 commented Jun 16, 2021

Why:

Fix a typo

What's being changed:

Run brower-test --> Run browser-test

Check off the following:

  • [N/A] I have reviewed my changes in staging (look for the deploy-to-heroku link in your pull request, then click View deployment).
  • For content changes, I have completed the self-review checklist.

@ajs256 ajs256 requested a review from a team as a code owner June 16, 2021 18:45
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 16, 2021
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
scripts/**
translations/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@ajs256
Copy link
Contributor Author

ajs256 commented Jun 16, 2021

This doesn't actually change the workflows in any way. I'm assuming the bot can be overridden by its human overlords.

@heiskr heiskr removed the request for review from a team June 17, 2021 15:10
Copy link
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @ajs256!

@janiceilene janiceilene dismissed github-actions[bot]’s stale review June 18, 2021 21:53

Update doesn't impact workflow

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
scripts/**
translations/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@janiceilene janiceilene dismissed github-actions[bot]’s stale review June 18, 2021 21:57

Still doesn't impact the workflow

@github github deleted a comment Jun 18, 2021
@janiceilene janiceilene added ready to merge This pull request is ready to merge and removed triage Do not begin working on this issue until triaged by the team labels Jun 18, 2021
@janiceilene
Copy link
Contributor

It looks like we're having some trouble with our staging checks. I'll come back to get this merged next week! Sorry about the delay 💛

@ajs256
Copy link
Contributor Author

ajs256 commented Jun 18, 2021

No problem.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
scripts/**
translations/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
scripts/**
translations/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@ajs256 ajs256 deleted the patch-3 branch June 22, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants