Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generating-a-new-gpg-key.md #7433

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented Jun 16, 2021

Why:

The interactive gpg key creation flow is different to how the docs here make them sound. I've made it less specific so as not to confuse people.

Check off the following:

  • I have reviewed my changes in staging (look for the deploy-to-heroku link in your pull request, then click View deployment).
  • For content changes, I have completed the self-review checklist.

The interactive gpg key creation flow is different to how the docs here make them sound. I've made it less specific so as not to confuse people.
@welcome
Copy link

welcome bot commented Jun 16, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 16, 2021
@corneliusroemer
Copy link
Contributor Author

@Alisonhattingh thanks for approving changes. It may be necessary to explicitly approve running workflows since I'm a first-time contributor:
image

@janiceilene
Copy link
Contributor

Thanks so much for opening a PR @corneliusroemer! I'll get this triaged for a review by one of the GitHub Docs writers ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jun 18, 2021
Copy link
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'll merge now. Thanks! ⚡

@lecoursen lecoursen enabled auto-merge June 22, 2021 13:45
@lecoursen lecoursen merged commit 7effa79 into github:main Jun 22, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants