Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the color of the warning links #5781

Merged
merged 3 commits into from
Apr 27, 2021
Merged

Change the color of the warning links #5781

merged 3 commits into from
Apr 27, 2021

Conversation

lucalves
Copy link
Contributor

Why:

As reported in Issue #5349, the color of the link in the notices is unreadable due to the blue background.
I changed it to the color -color-bg-info of premier.style.

With the change, it will look like this:

link-color

This will also affect documentation in Portuguese, Spanish and Japanese, in addition to Chinese.

Closes #5349.

What's being changed:

Check off the following:

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 27, 2021
@chiedo chiedo requested a review from heiskr April 27, 2021 19:48
@heiskr
Copy link
Contributor

heiskr commented Apr 27, 2021

I suspect we want to change the background color of the banner instead of the link color. 🙏🏼

@lucalves
Copy link
Contributor Author

I suspect we want to change the background color of the banner instead of the link color. 🙏🏼

Hi, @heiskr! I tested it by changing the background color and it really got better. However, I am not allowed to make this change, since the .css file that enables this change is inside the /dist folder and this folder is in the project's .gitignore file.

What to do in this situation?

@heiskr
Copy link
Contributor

heiskr commented Apr 27, 2021

I think the file you want to update is includes/header-notification.html, color-bg-info-inverse

@lucalves lucalves requested a review from a team as a code owner April 27, 2021 21:23
@lucalves
Copy link
Contributor Author

lucalves commented Apr 27, 2021

I think the file you want to update is includes/header-notification.html, color-bg-info-inverse

You're right, thanks. I include the necessary changes.

@heiskr heiskr enabled auto-merge (squash) April 27, 2021 21:27
@heiskr heiskr merged commit e1ab94f into github:main Apr 27, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blue link text in notices is unreadable due to blue background
2 participants