Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that the Actions Skipper never errors out #558

Merged
merged 4 commits into from
Oct 15, 2020
Merged

Ensure that the Actions Skipper never errors out #558

merged 4 commits into from
Oct 15, 2020

Conversation

chiedo
Copy link
Contributor

@chiedo chiedo commented Oct 15, 2020

Make sure that if the duplicate actions checker fails, it still shows a successful check. As the Actions skipper is non-blocking.

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging.

@chiedo chiedo requested a review from a team as a code owner October 15, 2020 16:50
JasonEtco
JasonEtco approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@JasonEtco JasonEtco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice, we should have caught this in earlier reviews 🤦

@chiedo chiedo merged commit 6eac005 into main Oct 15, 2020
@chiedo chiedo deleted the continue-skip-check-on-error branch October 15, 2020 17:57
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

This was referenced Dec 27, 2020
Open
Merged
@Anmar1988260 Anmar1988260 mentioned this pull request Feb 6, 2021
Merged
@montana910318 montana910318 mentioned this pull request Feb 7, 2021
Open
@codywalker77 codywalker77 mentioned this pull request Feb 18, 2021
Merged
@w124578 w124578 mentioned this pull request Feb 21, 2021
Merged
@trongham trongham mentioned this pull request Feb 25, 2021
Open
@KunKaxx KunKaxx mentioned this pull request Feb 28, 2021
Merged
@Dmarch28 Dmarch28 mentioned this pull request Mar 10, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Apr 15, 2021
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 30, 2021
Open
@snyk-bot snyk-bot mentioned this pull request May 8, 2021
Open
@snyk-bot snyk-bot mentioned this pull request May 18, 2021
Open
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
@Loquacity @zseta @jacobprall
Update tutorials for more inclusive language (github#558)
9847d2c 
* s/master/main

* Update timescaledb/tutorials/aws-lambda/continuous-deployment.md

Co-authored-by: Attila Tóth <[email protected]>

Co-authored-by: Attila Tóth <[email protected]>
Co-authored-by: Jacob Prall <[email protected]>
@camwhite-121 camwhite-121 mentioned this pull request Jun 20, 2023
Open
@zipzip225 zipzip225 mentioned this pull request Jun 20, 2023
Open
@ros2-ship ros2-ship mentioned this pull request Jun 20, 2023
Open
@avengerfart avengerfart mentioned this pull request Jun 20, 2023
Open
@trongham trongham mentioned this pull request Jun 20, 2023
Open
@eddiephoen123 eddiephoen123 mentioned this pull request Jun 20, 2023
Open
@Ismetyt Ismetyt mentioned this pull request Jun 20, 2023
Open
@lilmoonlil lilmoonlil mentioned this pull request Jul 29, 2023
Open
This was referenced Aug 8, 2023
Open
Open
Open
@juwan-crypto juwan-crypto mentioned this pull request Oct 12, 2023
Open
@lilmoonlil lilmoonlil mentioned this pull request Oct 17, 2023
Open
@tglt-9794 tglt-9794 mentioned this pull request Nov 30, 2023
Open
@treeations treeations mentioned this pull request Nov 30, 2023
Open
@RanaAhmed2020 RanaAhmed2020 mentioned this pull request Nov 30, 2023
Open
@vutting4221 vutting4221 mentioned this pull request Nov 30, 2023
Open
@chrisjcox79 chrisjcox79 mentioned this pull request Nov 30, 2023
Open
@BESTczm BESTczm mentioned this pull request Nov 30, 2023
Open
@zipzip225 zipzip225 mentioned this pull request Nov 30, 2023
Open
@amymariaparker2401 amymariaparker2401 mentioned this pull request Nov 30, 2023
Open
@rhsayem075 rhsayem075 mentioned this pull request Nov 30, 2023
Open
@machatman machatman mentioned this pull request Nov 30, 2023
Open
@montana910318 montana910318 mentioned this pull request Nov 30, 2023
Open
@makombelajob makombelajob mentioned this pull request Nov 30, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Nov 30, 2023
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this pull request Nov 30, 2023
Open
@qmutz qmutz mentioned this pull request Nov 30, 2023
Open
@oudomskn oudomskn mentioned this pull request Nov 30, 2023
Open
@Visva92 Visva92 mentioned this pull request Nov 30, 2023
Open
@Oleksandr1201vsp Oleksandr1201vsp mentioned this pull request Nov 30, 2023
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this pull request Dec 1, 2023
Open
@monzerfoda monzerfoda mentioned this pull request Dec 1, 2023
Open
@mongoloidkhulmikuki366385 mongoloidkhulmikuki366385 mentioned this pull request Dec 1, 2023
Open
@Manny27nyc Manny27nyc mentioned this pull request Dec 1, 2023
Open
@mongoloidkhulmikuki366385 mongoloidkhulmikuki366385 mentioned this pull request Dec 1, 2023
Open
@avengerfart avengerfart mentioned this pull request Dec 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonEtco JasonEtco JasonEtco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chiedo @JasonEtco