Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

per_page paragraph removed from RESTAPI/ Reference/ Activity/ Events #4362

Merged
merged 2 commits into from
Mar 16, 2021
Merged

per_page paragraph removed from RESTAPI/ Reference/ Activity/ Events #4362

merged 2 commits into from
Mar 16, 2021

Conversation

vivekshotti
Copy link
Contributor

@vivekshotti vivekshotti commented Mar 8, 2021

Why:

Closes [#1668]

What's being changed:

section mentioning per_page is unsupported and should be removed:

image

Removed the above paragraph from RESTAPI/ Reference/ Activity/ Events.

You can check the changes (deployment) here

Check off the following:

@github-actions
Copy link
Contributor

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Mar 15, 2021
@vivekshotti
Copy link
Contributor Author

Hey mods! Please check this PR!

@janiceilene janiceilene linked an issue Mar 16, 2021 that may be closed by this pull request
Copy link
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for removing this paragraph @Vivek-Hotti! Your changes look great! I'm going to update the branch and once tests are passing, I'll get this merged ⚡ Thanks for your patience, I was out last week 💛

I've linked the issue to this PR (I used the sidebar, but you can also use closes #1668 in the pull request template), so that once the PR is merged, the issue will automatically close.

@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale There is no recent activity on this issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events documentation and per_page param
2 participants