Added pusher_type to create_properties and delete_properties webhooks #4348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Closes [#3192 ]
What's being changed:
So apparently The docs for
DeleteEvent
mention two fields,ref
, andref_type
. However, there is a third field that appears in API calls,pusher_type
. It seems pusher_type should also appear in the docs.@skedwards88 later also pointed out that
pusher_type
is in the payload forDeleteEvent
and also forCreateEvent
, with values that can beuser
or a deploy key.I've added the same in the reusable webhooks of create_properties and delete_properties.
You could view the successful deployment here
Check off the following: