Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pusher_type to create_properties and delete_properties webhooks #4348

Closed
wants to merge 4 commits into from
Closed

Conversation

vivekshotti
Copy link
Contributor

@vivekshotti vivekshotti commented Mar 7, 2021

Why:

Closes [#3192 ]

What's being changed:

So apparently The docs for DeleteEvent mention two fields, ref, and ref_type. However, there is a third field that appears in API calls, pusher_type. It seems pusher_type should also appear in the docs.

@skedwards88 later also pointed out that pusher_type is in the payload for DeleteEvent and also for CreateEvent, with values that can be user or a deploy key.

I've added the same in the reusable webhooks of create_properties and delete_properties.
You could view the successful deployment here

Check off the following:

@welcome
Copy link

welcome bot commented Mar 7, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Sepokepoi123
Sepokepoi123 previously approved these changes Mar 7, 2021
@vivekshotti vivekshotti closed this Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants