Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support banner container #388

Merged
merged 3 commits into from
Oct 22, 2020
Merged

add support banner container #388

merged 3 commits into from
Oct 22, 2020

Conversation

Arhell
Copy link
Contributor

@Arhell Arhell commented Oct 10, 2020

Why:

fix issue

What's being changed:

fix support banner block add container for large monitors

Check off the following:

@Arhell Arhell mentioned this pull request Oct 12, 2020
Closed
@Arhell
Copy link
Contributor Author

Arhell commented Oct 12, 2020

review page https://docs-388--fix-support-banner.herokuapp.com/en

@janiceilene janiceilene added the design Will involve design/engineering label Oct 12, 2020
heiskr
heiskr approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏼 Thanks!

@janiceilene janiceilene merged commit 5ba70b2 into github:main Oct 22, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@Arhell Arhell deleted the fix-support-banner branch October 22, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heiskr heiskr heiskr approved these changes

Assignees
No one assigned
Labels
design Will involve design/engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support banner without container
3 participants
@Arhell @heiskr @janiceilene