-
Notifications
You must be signed in to change notification settings - Fork 60.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: mismatch between explanation and code in triggers #33783
docs: mismatch between explanation and code in triggers #33783
Conversation
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@gagan-bhullar-tech Hello! 👋 Thank you for opening a PR! We will need to put this PR on hold for now until the issue this PR is linked to has been reviewed by the team 💛 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gagan-bhullar-tech - Many thanks for raising this PR with these changes.
As a result of feedback we've had, we are currently making an effort to reduce the number of links between articles, except where necessary to the understanding of the current article, so I've suggested removing the links here.
If you'd like to click to commit my suggestions then I'll approve this and we can get this merged next week once the current repo freeze is lifted.
Thanks again for working on this.
👍
content/actions/publishing-packages/publishing-docker-images.md
Outdated
Show resolved
Hide resolved
content/actions/publishing-packages/publishing-docker-images.md
Outdated
Show resolved
Hide resolved
@hubwriter thanks. Incorporated both changes. |
@gagan-bhullar-tech - Many thanks. We'll merge this next week after the current repo freeze is lifted. |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why: To fix mismatch between explanation and code in triggers
Closes: #33777
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.