-
Notifications
You must be signed in to change notification settings - Fork 60.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an item with github source authentication to the dotnet CLI in the instructions for GitHub Packages #33314
Conversation
…gistry github source
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@Falcion Thanks so much for opening a PR! I'll get this triaged for review ✨ |
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step already exists in the "Authenticating to GitHub Packages" section of the documentation, although it is formatted for use in a GitHub Actions workflow. I think the confusion is understandable, though.
I would suggest removing these two changes and moving the new part up to the above section. Use YOUR_GITHUB_PAT
to match other examples instead of ${{ secrets.GITHUB_TOKEN }}
. Mention that it is a command that can be run directly from the command line using the dotnet
CLI instead of manually configuring a nuget.config
file. Also check the spelling of "Authenticate" 👍
content/packages/working-with-a-github-packages-registry/working-with-the-nuget-registry.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Jacob Wallraff <[email protected]>
1. Removed duplicates about auth; 2. Moved authentification with CLI into the "Publishing a package" 3. Replaced `${{ secrets.GITHUB_TOKEN }}` with `YOUR_GITHUB_PAT`
I apologize for the "spammy" commits with fixes and adjustments to your answer. As was mentioned in the discussion, I removed the “duplicate” authorizations, changed |
@Falcion Thank you so much for that last batch of adjustments! 💛 I'll update the branch and get this merged once tests are passing 🍏 |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
The article itself, although contains information on how to authenticate
github
source for NuGet integration with GitHub Packages still indicate GitHub Actions in the title, which can confuse a user who is working with GitHub Packages for the first time and is trying to upload their project manually (again usingdotnet
CLI)Example of this experience is this discussion: https://github.com/orgs/community/discussions/49186
What's being changed (if available, include any code snippets, screenshots, or gifs):
Update guide in Publishing a package and Publishing a package using a nuget.config file and add step about authenticating GitHub Packages for user:
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.