-
Notifications
You must be signed in to change notification settings - Fork 60.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update merging-a-pull-request.md and fix #26546 #26547
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@Winson-Huang Thank you for opening a PR and linking it to your issue! We appreciate all the extra context provided in the issue ✨ And welcome to the community! I'll get this triaged for review! ⚡ In the meantime, if you'd like to find other ways to contribute, check out our help wanted section to find open issues you can work on. 👍 |
Thanks for your response, I'd like someone to review this PR |
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
Hi @Winson-Huang 👋 Thanks for creating a PR and contributing to our docs, we really appreciate it! ✨ However, after careful consideration, we've found that your suggested change is not needed at the moment because the docs are accurate. In the issue you raised, you mentioned:
While we value your input, we must clarify that our existing documentation covers this scenario. The "Rebase and merge your commits" section says:
Since we have the information correctly represented, we have decided to close this PR. Nevertheless, we really appreciate you contributing to the community, and we encourage you to continue contributing in the future! 💖 Keep up the fantastic work! 🌟 |
Please see my response in initial issue#26546, and consider reopen this PR if needed, thanks. |
Why:
Closes: #26546
What's being changed (if available, include any code snippets, screenshots, or gifs):
https://github.com/github/docs/blob/main/content/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/merging-a-pull-request.md
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
data
directory.For content changes, I have completed the self-review checklist.