Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update countries-where-sms-authentication-is-supported.md #24567

Closed
wants to merge 1 commit into from

Conversation

pingren
Copy link

@pingren pingren commented Mar 21, 2023

Why:

This Pull Request replaces the term country with country/region for disputed areas (such as Taiwan) in the documentation about SMS authentication.

This change follows the practice of other docs from Microsoft, aligns with GitHub's diversity and inclusion values, and avoids political controversy.

Reference:

PS: the Enable two-factor authentication (2FA) page should update accordingly

CleanShot 2023-03-21 at 12 07 44

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Mar 21, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 21, 2023
@github-actions
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/securing-your-account-with-two-factor-authentication-2fa/countries-where-sms-authentication-is-supported.md fpt
ghec
fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@pingren Thanks so much for opening a PR! We appreciate the added references! 💖

I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review authentication Content relating to authentication and removed triage Do not begin working on this issue until triaged by the team labels Mar 21, 2023
@martinwoodward
Copy link
Contributor

I've created an issue internally with the team that own that part of the UI. Once it is updated they will update the associated documentation as part of fixing that page.

Thank you for bringing the matter to our attention ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants