Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes breaking base64 command options change in OSX 13.0+ #22970

Merged
merged 4 commits into from
Jan 17, 2023
Merged

Fixes breaking base64 command options change in OSX 13.0+ #22970

merged 4 commits into from
Jan 17, 2023

Conversation

mikemike396
Copy link
Contributor

@mikemike396 mikemike396 commented Jan 3, 2023

Why:

OSX 13.0+ now requires the base64 command to pass the output file in one the following 2 formats. (https://www.unix.com/man-page/osx/1/base64/)

-o output_file
--output=output_file

What's being changed (if available, include any code snippets, screenshots, or gifs):

This command works in OSX 12 but not in 13:

echo -n "$BUILD_CERTIFICATE_BASE64" | base64 --decode --output $CERTIFICATE_PATH

Pipeline throws error:
base64: invalid argument --output

This works in both:

echo -n "$BUILD_CERTIFICATE_BASE64" | base64 --decode -o $CERTIFICATE_PATH

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

…elopment.md

Updated base64 command output option format.
@welcome
Copy link

welcome bot commented Jan 3, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/deployment/deploying-xcode-applications/installing-an-apple-certificate-on-macos-runners-for-xcode-development.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@mikemike396 Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jan 4, 2023
@Amirdarabi1377

This comment was marked as spam.

Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed description of the issue, and for this fix, @mikemike396!

I'll get this merged 🚀

@lucascosti lucascosti enabled auto-merge (squash) January 17, 2023 22:51
@lucascosti lucascosti merged commit f6b9bf6 into github:main Jan 17, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@mikemike396 mikemike396 deleted the patch-1 branch January 19, 2023 00:02
atulsmadhugiri added a commit to atulsmadhugiri/Blob that referenced this pull request Jun 3, 2023
infeo added a commit to cryptomator/cli that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants