Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix git config command syntax in "Telling Git about your signing key" #22000

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Fix git config command syntax in "Telling Git about your signing key" #22000

merged 2 commits into from
Nov 14, 2022

Conversation

ajhall
Copy link
Contributor

@ajhall ajhall commented Nov 14, 2022 •
edited
Loading

Why:

Closes #21999

What's being changed (if available, include any code snippets, screenshots, or gifs):

git config expects a space between the key and value rather than an equals sign.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@ajhall
Fix git config command syntax
30ed2b5 
`git config` expects a space between the key and value rather than an equals sign.
@welcome
Copy link

welcome bot commented Nov 14, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 14, 2022
@cmwilson21
Copy link
Contributor

@ajhall Thank you for opening a PR and linking it to your issue! ✨

I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review authentication Content relating to authentication ssh Content related to SSH and removed triage Do not begin working on this issue until triaged by the team labels Nov 14, 2022
cmwilson21
cmwilson21 approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@cmwilson21 cmwilson21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✨

@cmwilson21
Copy link
Contributor

Thanks for the catch! I'll get this merged down once all the tests have passed. ✅

@cmwilson21 cmwilson21 added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Nov 14, 2022
@cmwilson21 cmwilson21 merged commit 9fe90a9 into github:main Nov 14, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmwilson21 cmwilson21 cmwilson21 approved these changes

Assignees
No one assigned
Labels
authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge ssh Content related to SSH
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect git config command syntax in "Telling Git about your signing key"
2 participants
@ajhall @cmwilson21