-
Notifications
You must be signed in to change notification settings - Fork 60k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update working-with-ssh-key-passphrases.md #2188
Conversation
This is a follow-up on github#876 (comment) to address another article affected. Changes proposed are to align with the article "Generating a new SSH key and adding it to the ssh-agent".
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@faruqluqman Thanks so much for opening a PR! I'll get this triaged for review 💖 |
@janiceilene Is it okay? |
👋 @faruqluqman I've triaged your pull request and a writer from the team will review it next! We may be a bit slow to review, since most folks are currently out for the holidays 🎄 |
content/github/authenticating-to-github/working-with-ssh-key-passphrases.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@faruqluqman - Many thanks for raising this PR. Apologies for the delay reviewing it.
I've made a couple of suggestions for changes.
content/github/authenticating-to-github/working-with-ssh-key-passphrases.md
Outdated
Show resolved
Hide resolved
content/github/authenticating-to-github/working-with-ssh-key-passphrases.md
Outdated
Show resolved
Hide resolved
content/github/authenticating-to-github/working-with-ssh-key-passphrases.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been a while since this was raised. No reply from the author but I think my requested changes were simple and uncontroversial, so I've applied them now.
This is good to merge.
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
Why:
This is a follow-up on #876 (comment) to address another article affected.
What's being changed:
Changes to the code block under "Adding or changing a passphrase" to align with the article "Generating a new SSH key and adding it to the ssh-agent".
Check off the following: