Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update working-with-ssh-key-passphrases.md #2188

Merged
merged 6 commits into from
Jan 14, 2021
Merged

Conversation

faruqluqman
Copy link
Contributor

@faruqluqman faruqluqman commented Dec 17, 2020

Why:

This is a follow-up on #876 (comment) to address another article affected.

What's being changed:

Changes to the code block under "Adding or changing a passphrase" to align with the article "Generating a new SSH key and adding it to the ssh-agent".

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

This is a follow-up on github#876 (comment) to address another article affected.
Changes proposed are to align with the article "Generating a new SSH key and adding it to the ssh-agent".
@welcome
Copy link

welcome bot commented Dec 17, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Dec 17, 2020
@janiceilene
Copy link
Contributor

@faruqluqman Thanks so much for opening a PR! I'll get this triaged for review 💖

@faruqluqman
Copy link
Contributor Author

@faruqluqman Thanks so much for opening a PR! I'll get this triaged for review

@janiceilene Is it okay?

@janiceilene
Copy link
Contributor

👋 @faruqluqman I've triaged your pull request and a writer from the team will review it next! We may be a bit slow to review, since most folks are currently out for the holidays 🎄

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 29, 2020
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faruqluqman - Many thanks for raising this PR. Apologies for the delay reviewing it.

I've made a couple of suggestions for changes.

@github github deleted a comment from github-actions bot Jan 4, 2021
@hubwriter hubwriter self-assigned this Jan 4, 2021
@github github deleted a comment Jan 11, 2021
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a while since this was raised. No reply from the author but I think my requested changes were simple and uncontroversial, so I've applied them now.

This is good to merge.

@hubwriter hubwriter merged commit 79b9dbc into github:main Jan 14, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team stale There is no recent activity on this issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants