Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update nodejs template guide to match node versions #2158

Merged
merged 7 commits into from
Jan 14, 2021
Merged

docs: update nodejs template guide to match node versions #2158

merged 7 commits into from
Jan 14, 2021

Conversation

ghinks
Copy link
Contributor

@ghinks ghinks commented Dec 16, 2020 •
edited
Loading

The node versions that are maintained as part of the LTS (long term support plan) have incremented by 2 in accordance with LTS Plan. The nodeJS starter templates were updated and I am updating these docs to reflect that.

Sincere thanks for github actions!

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@ghinks
docs: update nodejs template guide to match node versions
cd6d7aa 
The node versions that are maintained as part of the LTS (long term support plan) have incremented by 2 in accordance with [LTS Plan](https://nodejs.org/en/about/releases/). The [nodeJS starter templates](https://github.com/actions/starter-workflows/blob/main/ci/node.js.yml) were updated and I am updating these docs to reflect that.

Sincere thanks for github actions!
@welcome
Copy link

welcome bot commented Dec 16, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

@ghinks Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Dec 16, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 24, 2020
@ghinks
Copy link
Contributor Author

ghinks commented Dec 27, 2020

The pr is still valid

@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Dec 28, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2021

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 4, 2021
@janiceilene
Copy link
Contributor

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions after the holidays ✨

@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 5, 2021
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 12, 2021
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 12, 2021
@shati-patel shati-patel self-assigned this Jan 13, 2021
shati-patel
shati-patel suggested changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing those outdated examples @ghinks, and apologies for the late review!

The template file has actually changed again, for example to include version 15.x, add on: pull_request:, and remove the env syntax.

Would you be able to copy in those changes too? Then I'll get this merged shortly. Thank you again for your help! ✨

@ghinks
Copy link
Contributor Author

ghinks commented Jan 13, 2021

Will look after breakfast

ghinks and others added 3 commits January 13, 2021 09:31
@ghinks
Update building-and-testing-nodejs.md
66c0632 
Adding updates due to template changes. 

The github action is now including 10-15, which is 4 versions following the LTS release schedule
@shati-patel
Remove old "env" syntax and update example
9aebacd
@shati-patel
Change "install" to "ci" (from template)
8c463ee
shati-patel
shati-patel approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates, @ghinks! I've also added a small change to remove the env: step (since that was also deleted from the template).

If you're happy with the change, I will get this merged 😃

@ghinks
Copy link
Contributor Author

ghinks commented Jan 14, 2021

Yes, well spotted. Pls merge. 👍🏼

@shati-patel shati-patel merged commit 346d762 into github:main Jan 14, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@snyk-bot snyk-bot mentioned this pull request Sep 2, 2021
Open
@Z-byte-prog Z-byte-prog mentioned this pull request Aug 28, 2023
Closed
@kavirmusic kavirmusic mentioned this pull request Sep 4, 2023
Open
@RhinosF1 RhinosF1 mentioned this pull request Nov 5, 2023
Open
@colorado392 colorado392 mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shati-patel shati-patel shati-patel approved these changes

Assignees

@shati-patel shati-patel

Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghinks @janiceilene @shati-patel