-
Notifications
You must be signed in to change notification settings - Fork 60k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: inconsistent punctuation in understanding-github-actions.md
#20079
Conversation
Punctuation like periods come **before** the ending quotation mark in the US. All other quotation marks in the document use `."`, this was the only one that placed the period after the closing quotation mark.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@ImUnlikely Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for spotting this and offering a fix! I'll get this merged down once the tests have all passed 🍏 |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Punctuation like periods come before the ending quotation mark in the US. All other quotation marks in the document use
."
, this was the only one that placed the period after the closing quotation mark.What's being changed (if available, include any code snippets, screenshots, or gifs):
Moved period one place left so it comes before the closing quotation mark.
Check off the following:
Writer impact (This section is for GitHub staff members only):