Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JetBrains installation instructions #18860

Merged
merged 4 commits into from
Jul 14, 2022
Merged

Conversation

vincentpaca
Copy link
Contributor

Why:

There are minor inaccuracies on the installation instructions and also missing context that helps to find the relevant sections described in the steps.

Closes [issue link]

What's being changed (if available, include any code snippets, screenshots, or gifs):

  • Add the window naming nuances for Windows and Mac
  • Add the extra step to find the Plugins section as previously it just asked to find the Marketplace button at the top of the window.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

* Add the window naming nuances for Windows and Mac
* Add the extra step to find the **Plugins** section as previously it just asked to find the **Marketplace** button at the top of the window.
@welcome
Copy link

welcome bot commented Jun 29, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
copilot/getting-started-with-github-copilot/getting-started-with-github-copilot-in-a-jetbrains-ide.md fpt
ghec
fpt
ghec

@cmwilson21
Copy link
Contributor

@vincentpaca Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review copilot Content related to GitHub Copilot and removed triage Do not begin working on this issue until triaged by the team labels Jun 29, 2022
Copy link
Contributor

@jules-p jules-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vincentpaca 👋🏻 thanks so much for opening this pull request, we really appreciate your contribution. I've made a couple of small edits to the wording to align with our style guide, but otherwise I think this is looking great! I'll go ahead and merge these changes now ✨

@jules-p jules-p merged commit b189807 into github:main Jul 14, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team copilot Content related to GitHub Copilot waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants