Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto merge dependabot updates #177

Merged
merged 7 commits into from
Oct 8, 2020

Conversation

tjenkinson
Copy link
Contributor

@tjenkinson tjenkinson commented Oct 7, 2020

Why:

There isn't an existing issue, but I thought this was small enough it probably doesn't need one.

This action (disclaimer: I wrote it) will automerge dependabot PRs that do not contain a major version change when required checks pass. Thought it might be useful.

What's being changed:

Adds an action to automerge dependebot PR's.

Check off the following:

@welcome
Copy link

welcome bot commented Oct 7, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 7, 2020
@tjenkinson tjenkinson marked this pull request as ready for review October 7, 2020 17:58
@tjenkinson tjenkinson requested a review from a team as a code owner October 7, 2020 17:58
@zeke
Copy link
Contributor

zeke commented Oct 7, 2020

Hi @tjenkinson 👋🏼

Thanks for opening the PR. I think you may be the first external contributor to open a pull request on this newly-public repository! 🎁

I love the idea of this change, and agree that we should automate things like @dependabot PRs. But we also need to be careful about adding third-party Actions to our codebase without first conducting a security audit. I'll need to discuss this with the @github/docs-engineering team to figure out how we'd like to proceed. We'll get back to you soon.

@zeke zeke changed the title auto merge dependadabot updates auto merge dependabot updates Oct 7, 2020
@tjenkinson
Copy link
Contributor Author

Awesome! Thanks for the speedy reply :)

No rush. It works well for me but no worries if you go with something else.

@zeke
Copy link
Contributor

zeke commented Oct 7, 2020

I discussed this with the team and I think we'll be able accept this change, but first: #180

@tjenkinson tjenkinson mentioned this pull request Oct 7, 2020
4 tasks
Copy link
Contributor

@zeke zeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: I audited the code at https://github.com/tjenkinson/gh-action-auto-merge-dependency-updates/blob/0882a8edde9070b608c8f19837f2a545bf6f2c28/src/run.ts#L61-L64 and it looks reasonable to me. 👍🏼

@tjenkinson if you can now add your Action to .github/allowed-actions.js, this should turn green again:

tjenkinson/gh-action-auto-merge-dependency-updates@0882a8e

Once that's done, we can ship it!

@zeke zeke added engineering Will involve Docs Engineering and removed triage Do not begin working on this issue until triaged by the team labels Oct 8, 2020
@tjenkinson
Copy link
Contributor Author

Done! I’m not sure if it will work properly right now though actually because it looks like a reviewer is required so it still might not have permission to merge automatically?

@tjenkinson
Copy link
Contributor Author

Looks like on #286 for example the bot also approves the pr, but not sure where that’s happening from. Can add an option for that to the action if needed

@tjenkinson
Copy link
Contributor Author

I updated it to a newer version that will now also first approve the PR

Copy link
Contributor

@zeke zeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Let's give it a go.

@zeke zeke merged commit d5112be into github:main Oct 8, 2020
@zeke
Copy link
Contributor

zeke commented Oct 8, 2020

@all-contributors please add @tjenkinson for code

@allcontributors
Copy link
Contributor

@zeke

I've put up a pull request to add @tjenkinson! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Will involve Docs Engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants