Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update role and add missing label for search #1338

Merged
merged 2 commits into from
Nov 17, 2020

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Nov 14, 2020

Why:

pa11y is flagging the missing labeling on the Action example search page. When looking at the element flagged, noticed it was "text" rather than "search" as well

What's being changed:

Add a aria-label since there doesn't appear to be another label element and placeholder values aren't accessible

Check off the following:

@janiceilene
Copy link
Contributor

@nschonni Thanks so much for opening a PR! I'll get this triaged for review ✨

@janiceilene janiceilene added the engineering Will involve Docs Engineering label Nov 16, 2020
@chiedo chiedo self-requested a review November 17, 2020 13:37
@chiedo chiedo closed this Nov 17, 2020
@chiedo chiedo reopened this Nov 17, 2020
@chiedo chiedo merged commit f7ef8b8 into github:main Nov 17, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@nschonni nschonni deleted the action-search-pa11y branch November 17, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Will involve Docs Engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants