-
Notifications
You must be signed in to change notification settings - Fork 60k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Convert Standard to eslint-config-standard #1328
Conversation
@@ -146,13 +150,6 @@ | |||
"node": "12 - 14" | |||
}, | |||
"repository": "https://github.com/github/docs", | |||
"standard": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious about thoughts on including the eslint config and ignore in package.json instead of as separate files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the separate ignore file usually has better performance, but I've not looked at using the inline config in package.json before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good change to me and one that I've run into personally.
@nschonni thanks for creating this! Can you resolve the conflicts 🙏🏿 |
7334057
to
591bff9
Compare
- .filter must return a boolean value - .map replaced with forEach when the value isn't used
591bff9
to
795a74c
Compare
@chiedo done! |
Just want one more review on this one! @JasonEtco can you please review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for all the improvements here (and everywhere else) @nschonni!
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
Why:
Standard is a wrapper of opionated ESLint rules. By using the direct ESLint config, there is better integration with IDEs for showing ESLint errors while maintaining the existing style preference. Also can drop some of the JSX related dependencies that are bundled as part of the larger
standard
package.What's being changed:
standard
package and replace with the ESLint packages forstandard
Check off the following: