-
Notifications
You must be signed in to change notification settings - Fork 60k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new runner variable runner.arch
#12374
Conversation
Thanks for your submission. It appears that you've created a pull request using one of our repository's branches. Since this is Thanks again! |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate of #
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate of #
Need my commission account to start paying me
…Sent from my iPhone
On Nov 26, 2021, at 6:10 AM, mistaken-pull-closer[bot] ***@***.***> wrote:
Thanks for your submission.
It appears that you've created a pull request using one of our repository's branches. Since this is
almost always a mistake, we're going to go ahead and close this. If it was intentional, please
let us know what you were intending and we can see about reopening it.
Thanks again!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@fhammerl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this PR, @fhammerl!
Before we merge it, I just wanted to double check: because these new variables are set by the runner
app, I assume that this change isn't tied to specific GHES versions? i.e. a self-hosted runner attached to a GHES server will be able to use this environment variable after the runner
app is next automatically updated on the runner machine, regardless of the GHES instance version?
@lucascosti ☝️ that's correct, this is set in the runner. The change was shipped in runner v2.284.0. (afaik GHES 3.3 currently uses v2.283.3) |
ah, ok. In that case, I'll add some versioning to make this available to GHES versions 3.4 and above 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in staging: 👍
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Adding
runner.arch
variable after actions/runner#1185 is merged.What's being changed:
Context:
https://gha-docs-10389--add-runner-arc.herokuapp.com/en/actions/learn-github-actions/contexts#runner-context
Environment variable:
Check off the following: