Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new runner variable runner.arch #12374

Merged
merged 8 commits into from
Dec 2, 2021
Merged

Add new runner variable runner.arch #12374

merged 8 commits into from
Dec 2, 2021

Conversation

fhammerl
Copy link
Contributor

Why:

Adding runner.arch variable after actions/runner#1185 is merged.

What's being changed:

Context:

https://gha-docs-10389--add-runner-arc.herokuapp.com/en/actions/learn-github-actions/contexts#runner-context

Environment variable:

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

@mistaken-pull-closer
Copy link

Thanks for your submission.

It appears that you've created a pull request using one of our repository's branches. Since this is
almost always a mistake, we're going to go ahead and close this. If it was intentional, please
let us know what you were intending and we can see about reopening it.

Thanks again!

@mistaken-pull-closer mistaken-pull-closer bot added the invalid This issue/PR is invalid label Nov 26, 2021
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 26, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2021

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Staging Production What Changed
content/actions/learn-github-actions/contexts.md Modified Original
content/actions/learn-github-actions/environment-variables.md Modified Original

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of #

@ghost
Copy link

ghost commented Nov 26, 2021

Thanks for your submission.

It appears that you've created a pull request using one of our repository's branches. Since this is almost always a mistake, we're going to go ahead and close this. If it was intentional, please let us know what you were intending and we can see about reopening it.

Thanks again!

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of #

@Wiatt99923
Copy link

Wiatt99923 commented Nov 26, 2021 via email

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed invalid This issue/PR is invalid triage Do not begin working on this issue until triaged by the team labels Nov 29, 2021
@ramyaparimi ramyaparimi reopened this Nov 29, 2021
@ramyaparimi
Copy link
Contributor

@fhammerl
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 29, 2021
lucascosti
lucascosti previously approved these changes Dec 1, 2021
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR, @fhammerl!

Before we merge it, I just wanted to double check: because these new variables are set by the runner app, I assume that this change isn't tied to specific GHES versions? i.e. a self-hosted runner attached to a GHES server will be able to use this environment variable after the runner app is next automatically updated on the runner machine, regardless of the GHES instance version?

@fhammerl
Copy link
Contributor Author

fhammerl commented Dec 1, 2021

Thanks a lot for this PR, @fhammerl!

Before we merge it, I just wanted to double check: because these new variables are set by the runner app, I assume that this change isn't tied to specific GHES versions? i.e. a self-hosted runner attached to a GHES server will be able to use this environment variable after the runner app is next automatically updated on the runner machine, regardless of the GHES instance version?

@lucascosti ☝️ that's correct, this is set in the runner. The change was shipped in runner v2.284.0. (afaik GHES 3.3 currently uses v2.283.3)
If a self-hosted runner (regardless of GHES or dotcom version) is that version or higher, runner.arch is available.

@ramyaparimi ramyaparimi removed the triage Do not begin working on this issue until triaged by the team label Dec 1, 2021
@lucascosti
Copy link
Contributor

afaik GHES 3.3 currently uses v2.283.3

ah, ok. In that case, I'll add some versioning to make this available to GHES versions 3.4 and above 👍

Copy link
Contributor

@martin389 martin389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in staging: 👍

@lucascosti lucascosti merged commit bee380f into main Dec 2, 2021
@lucascosti lucascosti deleted the add-runner-arch-var branch December 2, 2021 01:16
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants