Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ambiguous keyboard shortcut to stop local server #11328

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Fix ambiguous keyboard shortcut to stop local server #11328

merged 3 commits into from
Nov 3, 2021

Conversation

AnilSeervi
Copy link
Contributor

Why:)

What's being changed:

  • Fix ambiguous keyboard shortcut to stop local server
  • link to nodenv docs
  • Fix typo lib/lanuages.js -> lib/languages.js
  • use <kbd> tag to show keyboard keys.

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! engineering Will involve Docs Engineering labels Oct 20, 2021
@ramyaparimi
Copy link
Contributor

@AnilSeervi
Thanks so much for opening a PR! I'll get this triaged for review ⚡

gracepark
gracepark approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@gracepark gracepark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@ramyaparimi ramyaparimi added the ready to merge This pull request is ready to merge label Oct 20, 2021
@ramyaparimi ramyaparimi enabled auto-merge October 21, 2021 11:29
@github-actions
Copy link
Contributor

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Oct 28, 2021
@ramyaparimi ramyaparimi added waiting for review Issue/PR is waiting for a writer's review and removed stale There is no recent activity on this issue or pull request labels Oct 29, 2021
@ramyaparimi ramyaparimi merged commit f7d4ee0 into github:main Nov 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@AnilSeervi AnilSeervi deleted the patch-3 branch November 15, 2021 11:03
@AnilSeervi AnilSeervi mentioned this pull request Dec 28, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gracepark gracepark gracepark approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team engineering Will involve Docs Engineering hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnilSeervi @ramyaparimi @gracepark @berettak910