-
Notifications
You must be signed in to change notification settings - Fork 60k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement]: Consistency for spelling of "canceled" in non-API docs #22624
Labels
good first issue
Good for newcomers
help wanted
Anyone is welcome to open a pull request to fix this issue
Comments
docs-bot
added
the
help wanted
Anyone is welcome to open a pull request to fix this issue
label
Dec 12, 2022
github-actions
bot
added
the
triage
Do not begin working on this issue until triaged by the team
label
Dec 12, 2022
cmwilson21
removed
the
triage
Do not begin working on this issue until triaged by the team
label
Dec 12, 2022
Hey, there! Would love to fix the issue if you assign it to me :) |
I would like to work on this |
Thank you both for your interest in improving the docs! ✨ We don't assign issues, so anyone is welcome to submit a PR for this fix. This sort of issue could include multiple PRs as it covers a large scope. 👍 |
This comment was marked as spam.
This comment was marked as spam.
schalkneethling
pushed a commit
to schalkneethling/docs
that referenced
this issue
Jan 6, 2023
Ensure the consistent use of canceled in prose. fix github#22624
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
Good for newcomers
help wanted
Anyone is welcome to open a pull request to fix this issue
Is this issue for a product update or release that is not yet available to customers?
No? Then please continue. Thank you!
What article(s) is affected?
The following files (corresponding to articles on docs.github.com and including REST content that's in Markdown) seem to use the word "cancelled" in prose:
There's a lot of use of "cancelled" in the REST API docs but a quick and dirty grep similar to the one above shows that all of it is related to products (ie it's canned in API requests/responses and we shouldn't change it/can't change it)
Describe the desired docs changes and the problem they solve for customers.
We should be using the word
canceled
(US English, described by MS Style guide) where appropriate in the documentation prose.Some of the instances of
cancelled
are in referential material like "Contexts," or status check functions like in "Expressions". Since these refer to GitHub Actions contexts or special functions, we shouldn't change them.Who does this affect?
Readers of docs
What is the impact to users?
Minimal impact, but there is a impression/reputation/consistency factor
Are you willing to open a PR to make this fix? If not, do you know anyone (Hubber or not, we're open source!) who's willing to help write this documentation?
Opening this for an OS contribution ✨
The text was updated successfully, but these errors were encountered: