Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update (write access required) message #1062

Merged
merged 4 commits into from
Sep 29, 2023

Conversation

Pantelis-Santorinios
Copy link
Contributor

Changing (write access required) to (write access to the repository is required to view the log) for clarity

Changing `(write access required)` to `(write access to the repository is required to view the log)`  for clarity
@Pantelis-Santorinios Pantelis-Santorinios requested a review from a team as a code owner September 28, 2023 09:43
@jurre
Copy link
Member

jurre commented Sep 28, 2023

Thanks @Pantelis-Santorinios! There's a couple of tests that check for this string, would you mind updating those as well? 🙇

updating the tests for the new string
@jurre
Copy link
Member

jurre commented Sep 28, 2023

Looking great, if you could just run npm run package and commit the results this looks good to go to me!

@mctofu
Copy link
Contributor

mctofu commented Sep 28, 2023

Assuming you are using a codespace, these are the steps needed to get npm run package to get the right output (should work locally too if you have nvm).

#### install the expected npm version
$ nvm install 
Found '/workspaces/dependabot-action/.nvmrc' with version <16.19.0>
Downloading and installing node v16.19.0...
Downloading https://nodejs.org/dist/v16.19.0/node-v16.19.0-linux-x64.tar.xz...
############################################################################################################################################### 100.0%
Computing checksum with sha256sum
Checksums matched!
Now using node v16.19.0 (npm v8.19.3)
#### make sure we've installed the right stuff for this npm version
$ npm clean-install

> [email protected] prepare
> husky install

husky - Git hooks installed

added 780 packages, and audited 781 packages in 12s

173 packages are looking for funding
  run `npm fund` for details

1 moderate severity vulnerability

To address all issues, run:
  npm audit fix

Run `npm audit` for details.
#### package it all up
$ npm run package


> [email protected] package
> ncc build -o dist/main src/main.ts --source-map --license licenses.txt && ncc build -o dist/cleanup src/cleanup.ts --source-map --license licenses.txt

ncc: Version 0.36.1
ncc: Compiling file index.js into CJS
ncc: Using [email protected] (local user-provided)
  40kB  dist/main/sourcemap-register.js
  43kB  dist/main/build/Release/cpufeatures.node
  50kB  dist/main/pagent.exe
  91kB  dist/main/lib/protocol/crypto/build/Release/sshcrypto.node
 130kB  dist/main/licenses.txt
2843kB  dist/main/index.js
2900kB  dist/main/index.js.map
2900kB  dist/main/index.js.map
6097kB  [8333ms] - ncc 0.36.1
ncc: Version 0.36.1
ncc: Compiling file index.js into CJS
ncc: Using [email protected] (local user-provided)
  40kB  dist/cleanup/sourcemap-register.js
  43kB  dist/cleanup/build/Release/cpufeatures.node
  50kB  dist/cleanup/pagent.exe
  68kB  dist/cleanup/licenses.txt
  91kB  dist/cleanup/lib/protocol/crypto/build/Release/sshcrypto.node
1092kB  dist/cleanup/index.js
1274kB  dist/cleanup/index.js.map
1274kB  dist/cleanup/index.js.map
2658kB  [6185ms] - ncc 0.36.1

@landongrindheim
Copy link
Member

Assuming you are using a codespace

☝️ In my experience, the npm run package output can vary between MacOS and Linux. Doing this in Codespaces will make this a little smoother (assuming the command was run on MacOS) 🙂

@Pantelis-Santorinios
Copy link
Contributor Author

Indeed it was a codespace and that seems to did the trick. Thanks.

@landongrindheim landongrindheim merged commit 286027e into github:main Sep 29, 2023
9 checks passed
@Pantelis-Santorinios Pantelis-Santorinios deleted the patch-1 branch October 2, 2023 05:58
@honeyankit honeyankit mentioned this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants