C++: Handle requires clauses and type template type constraints #18368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jketema
added
the
depends on internal PR
jketema
force-pushed
the
jketema/template-parameters-7
branch
from
09c0791 to
56b3e70
Compare
jketema
force-pushed
the
jketema/template-parameters-6
branch
from
a77b8f6 to
347edc4
Compare
jketema
force-pushed
the
jketema/template-parameters-7
branch
from
bf19755 to
bf7dd9b
Compare
jketema
force-pushed
the
jketema/template-parameters-7
branch
from
bf7dd9b to
0a292fb
Compare
There was a problem hiding this comment.
Copilot reviewed 6 out of 13 changed files in this pull request and generated no comments.
Files not reviewed (7)
- cpp/downgrades/dd32242a870867a532bb0b2a88a6a917a5b4c26f/upgrade.properties: Language not supported
- cpp/ql/lib/semmle/code/cpp/Function.qll: Language not supported
- cpp/ql/lib/semmle/code/cpp/TemplateParameter.qll: Language not supported
- cpp/ql/lib/semmle/code/cpp/UserType.qll: Language not supported
- cpp/ql/lib/semmle/code/cpp/Variable.qll: Language not supported
- cpp/ql/lib/semmlecode.cpp.dbscheme: Language not supported
- cpp/ql/lib/upgrades/1a4bbe5ded083b9de87911c155fc99ca22ecb0ce/upgrade.properties: Language not supported
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
calumgrant
approved these changes
Jan 10, 2025
| @@ -715,6 +715,27 @@ class FunctionDeclarationEntry extends DeclarationEntry, @fun_decl { | |||
| * specification. | |||
| */ | |||
| predicate isNoExcept() { fun_decl_empty_noexcept(underlyingElement(this)) } | |||
|
|
|||
| /** | |||
| * Gets a requires clause if this declaration is a template with such a clause. | |||
There was a problem hiding this comment.
I'm totally fine with the text, but sometimes if this declaration is a template with such a clause can be written as , if any.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
All query authors
.qhelp. See the documentation in this repository.Internal query authors only
.ql,.qll, or.qhelpfiles. See the documentation (internal access required).