Ruby: Start building the language pack using bazel. #15656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
criemen
force-pushed
the
criemen/ruby-bazel
branch
3 times, most recently
from
eecdfdb to
b3ea60f
Compare
aibaars
reviewed
Feb 22, 2024
aibaars
previously approved these changes
Feb 22, 2024
redsun82
reviewed
Feb 22, 2024
criemen
force-pushed
the
criemen/ruby-bazel
branch
from
b3ea60f to
c097397
Compare
redsun82
force-pushed
the
criemen/ruby-bazel
branch
from
52e4adc to
c097397
Compare
aibaars
previously approved these changes
Feb 26, 2024
This PR introduces a bazel and `rules_rust`-based build system for the ruby extractor and language pack. This replacese the existing, `cargo` and `cross`-based build system. For local development, nothing changes, and the existing `cargo`-based build still keeps working as-is. We no longer need to use `cross` to compile our Linux binaries, as we now can link against our hermetic C++ toolchain, which ships with an old enough glibc, so that we don't run into symbol version issues when deploying the binaries to older systems. Besides the one change in dependency (explained in detail in `Cargo.toml` and in #15595), nothing ought to change in how we build the extractor.
As we're now checking out the `codeql` repo in a sub-path, we need to enable long paths on Windows.
criemen
force-pushed
the
criemen/ruby-bazel
branch
from
debfe1b to
1657b31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a bazel and
rules_rust-based build system for the ruby extractor and language pack.This replaces the existing,
cargoandcross-based build system.For local development, nothing changes, and the existing
cargo-based build still keeps working as-is.We no longer need to use
crossto compile our Linux binaries, as we now can link against our hermetic C++ toolchain, which ships with an old enough glibc, so that we don't run into symbol version issues when deploying the binaries to older systems. However, this means that we no longer can run the centos-test with thegithub/codeql/cargo-based buildsystem, as the correct binaries will only be produced by the internal bazel setup.Besides the one change in dependency (explained in detail in
Cargo.tomland in #15595), nothing ought to change in how we build the extractor.