Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Update versionRe to include patch version #14234

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

mbg
Copy link
Member

@mbg mbg commented Sep 15, 2023

Cherry-picked from #14194. This updates the version regex to accept the new version format. Unfortunately, the regex failed to match at all before this change.

@mbg mbg added the Go label Sep 15, 2023
@mbg mbg requested a review from smowton September 15, 2023 15:37
@mbg mbg self-assigned this Sep 15, 2023
@mbg mbg requested a review from a team as a code owner September 15, 2023 15:37
@mbg mbg force-pushed the mbg/go/1.21-update-version-regex branch from b4b6d49 to 00f12e4 Compare September 15, 2023 15:38
smowton
smowton previously approved these changes Sep 15, 2023
@mbg mbg changed the base branch from main to rc/3.11 September 15, 2023 15:46
@mbg mbg dismissed smowton’s stale review September 15, 2023 15:46

The base branch was changed.

@mbg mbg requested review from a team as code owners September 15, 2023 15:46
@mbg mbg requested a review from a team September 15, 2023 15:46
@mbg mbg requested review from a team as code owners September 15, 2023 15:46
@mbg mbg changed the base branch from rc/3.11 to main September 15, 2023 15:46
@mbg mbg removed request for a team September 15, 2023 15:46
@mbg mbg removed request for a team September 15, 2023 15:46
@mbg mbg merged commit 8dd7602 into rc/3.11 Sep 15, 2023
2 checks passed
@mbg mbg deleted the mbg/go/1.21-update-version-regex branch September 15, 2023 16:23
@mbg mbg mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants