Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update screenshots for changes to variant analysis results view #13021

Merged
merged 2 commits into from
May 9, 2023

Conversation

shati-patel
Copy link
Contributor

We added/renamed the filtering and sorting options for the variant analysis results view (see github/vscode-codeql#2392). I've updated screenshots (and alt text) where necessary 📝

This behaviour won't be released for a few weeks, but the docs change is sufficiently small that it can merged/published any time!


By default, the results view shows All repositories, sorted by Number of results. Users can change these defaults in their settings (e.g. if they want to sort by Popularity by default, instead of manually clicking the dropdown every time). I didn't think it was worth calling that out explicitly, since we have a general article about "Customizing settings" already. Happy to be convinced otherwise though!

Expand for demo

I made a short screen recording in an internal issue. Cross-posting it here, for reference:

mrva-filter-sort.mp4

@shati-patel shati-patel requested a review from a team as a code owner May 3, 2023 16:03
@shati-patel shati-patel added the ready-for-doc-review This PR requires and is ready for review from the GitHub docs team. label May 3, 2023
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jules-p jules-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@oscarsj
Copy link
Contributor

oscarsj commented May 5, 2023

bumping the PR for triggering automated internal testing

@shati-patel shati-patel merged commit 4457126 into main May 9, 2023
@shati-patel shati-patel deleted the shati-patel/mrva-results-view branch May 9, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation ready-for-doc-review This PR requires and is ready for review from the GitHub docs team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants